Question on critical/deadly strike

[Jarulf]

I haven't even downloaded 1.10 yet, so can't check, although it should be trivial. However, lets clear up a thing. It is not an issue of attack "type". There is only one attack type (well for the purpose of this discussion). There is no "physical attack type" or "elemental attack type". There is simply an attack and the attack is composed of damage of various sorts. The damage calcs keep each damage type seperate until the very end where it adds them up for a final total damage so to speak. The critical hit/deadly strike works(or at least worked up to 1.09) on the part that was physical ONLY. For the purpose of Berserk, the damage was still in physical type at that point. Only later in the process of damage was the physical damage transformed into magical one.

The "after all" and meaning of all would be irelevant in that it applies after all additivie modifications. That is, it was a simply multiplicative addition to the current physical damage and all later modifications are of the same nature and hence the specific order of those are not important excpet from a academic point of view. The actual location in the damage code was changed in 1.08 or 1.09 and put slightly earlier than other modifications, but the end result is the same. As for the bug of Ruvanal, I am not familiar with it, nor can I comment on it. Seems more like an issue of the "resistance and damage modification code) than actual code that calcs the attack damage. The resistance code is for sure treated AFTER the damaga calc code for obvious reasons.

Please note that monster critical hit is a completely different issue and use special code specific for monsters and as allready said, applies to non physical damage too.